Skip to content

change logs guide #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025
Merged

change logs guide #919

merged 1 commit into from
May 1, 2025

Conversation

jbw976
Copy link
Member

@jbw976 jbw976 commented Apr 25, 2025

This PR adds a guide for enabling and using the change logs feature. It walks through a simple scenario with provider-kubernetes to enable change logs on the provider, create some resources and perform lifecycle operations on them, and how to check the change logs to learn more about the operations that were recorded.

I encourage reviewers to walk through the guide on the preview site and verify it works for them too. I have done so multiple times on my machine, but it would be good to get further validation.

Fixed #806

Copy link

netlify bot commented Apr 25, 2025

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit f35a1d6
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/68138e3c5c92b00008d67ed2
😎 Deploy Preview https://deploy-preview-919--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 83 (🟢 up 13 from production)
Accessibility: 90 (🔴 down 2 from production)
Best Practices: 83 (no change from production)
SEO: 100 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

It also assumes you have the [`jq` tool installed](https://jqlang.org/download/),
to perform lightweight querying and filtering of the content in the change logs.

The only other prerequisite for enabling change logs is that the provider must
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see folks asking how to detect if a provider includes the changelog feature. In the meantime, could we add a link tomain.go example from the provider-kubernetes project to help illustrate this? https://github.com/crossplane-contrib/provider-kubernetes/blob/3e694c4f2b644664167e67c58f3de8d2f9ffba0f/cmd/provider/main.go#L76

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i was thinking that was going to be a likely question also 😂 - but i don't love the idea of having people go search through source code of their providers

another idea could be to look at the help output of the provider image, e.g.:

❯ docker run --rm xpkg.crossplane.io/crossplane-contrib/provider-kubernetes:v0.17.1 --help 2>&1 | grep enable-changelogs
❯ docker run --rm xpkg.crossplane.io/crossplane-contrib/provider-kubernetes:v0.18.0 --help 2>&1 | grep enable-changelogs
      --[no-]enable-changelogs  Enable support for capturing change logs during

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was some offline discussion on a better long term approach that would allow packages to specify the features they support. That is not happening any time soon (it's just an idea right now), so can we punt on this for the first version of this guide and still get this otherwise very helpful material released on the docs site? 🙏

@jeanduplessis @haarchri

Copy link
Collaborator

@jeanduplessis jeanduplessis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one minor grammar fix proposal.

### Create a resource

Now that the provider is installed and configured with change logs enabled,
create a resource that will generates change logs entries reflecting the actions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
create a resource that will generates change logs entries reflecting the actions
create a resource that will generate change logs entries reflecting the actions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jeanduplessis for the review! i fixed this grammar issue 🙇‍♂️

Signed-off-by: Jared Watts <[email protected]>
@jbw976 jbw976 merged commit 7b445dc into crossplane:master May 1, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the change logs feature
3 participants